Add support for new placement mode #10937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 446b838 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ReppCodes
force-pushed
the
arepp/placement
branch
from
2a0c899 to
19fb70c
Compare
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
ReppCodes
force-pushed
the
arepp/placement
branch
3 times, most recently
from
1d62528 to
c48d9f7
Compare
ReppCodes
force-pushed
the
arepp/placement
branch
3 times, most recently
from
bee5ad1 to
c2da26f
Compare
ReppCodes
changed the title
vicb
reviewed
Nov 13, 2025
ReppCodes
force-pushed
the
arepp/placement
branch
6 times, most recently
from
f0003c2 to
06c7d17
Compare
Member
dario-piotrowicz
left a comment
dario-piotrowicz
left a comment
There was a problem hiding this comment.
Overall looks good but there are a few small things that could be improved I think 🙂
Member
|
Also, could you add a changeset for the workers-utils package as well? 🙏 |
ReppCodes
force-pushed
the
arepp/placement
branch
2 times, most recently
from
6e89cf4 to
630d939
Compare
Contributor
|
Looks good after the changes from Dario's reviews! Approved from me ✅ |
ReppCodes
force-pushed
the
arepp/placement
branch
2 times, most recently
from
ad0f589 to
c0c0a12
Compare
dario-piotrowicz
approved these changes
Dec 1, 2025
Add wrangler support for targeted placement Worker configurations. The relevant tests have been added or updated, and type-level enforcement of the new modes should prevent invalid formats from being passed through.
ReppCodes
force-pushed
the
arepp/placement
branch
from
c0c0a12 to
446b838
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the placement fields supported in config files to permit the fields expected by the new placement API.