fix: use dataItemColumnValueExtractor for grouping with nested objects#1200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #227
vibe coded a fix with Copilot
Description
Fixes issue #227 where grouping does not work with
dataItemColumnValueExtractorfor accessing nested object properties.Root Cause
When a column uses a custom
dataItemColumnValueExtractorto access nested objects and grouping is applied to that column, the DataView's grouping logic ignored the extractor and tried to access the field directly, resulting inundefinedvalues for grouping.Reproduction Steps
{ security: { fullName: 'foo' } }field: 'security'anddataItemColumnValueExtractorto extractsecurity.fullNameundefinedinstead of grouping by the extracted valuesSolution
getGroupingValue()helper method to DataView that:dataItemColumnValueExtractorextractGroups()to use this helper for string field gettersChanges
Columnimport andgetGroupingValue()methodTesting
dataItemColumnValueExtractorto expose nested propertiesImpact
syncGridSelection()or used by draggable grouping plugin)