add test coverage upload to codecov

[robfrank]

What does this PR do?

Add code coverage upload to codecov

[gemini-code-assist]

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

[mergify]

🧪 CI Insights

Here's what we observed from your CI run for 563652a.

🟢 All jobs passed!

But CI Insights is watching 👀

[claude]

Code Review

Thank you for adding Codecov integration! Here's my review:

Positives

1. Good security practice: SHA-pinned action consistent with project standards
2. Proper placement in the coverage-report job where files are aggregated
3. Reuses existing COVERAGE_FILES output, avoiding duplication
4. Non-blocking with fail_ci_if_error: false
5. Verbose logging enabled for troubleshooting

Key Issue: Missing Checkout Step

The coverage-report job lacks a checkout step. Codecov needs repository metadata (git info, commit SHA, branch) to properly associate coverage reports.

Recommendation: Add this as the first step in the coverage-report job:

- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

Other Observations

• The slug parameter is typically auto-detected and can be removed
• The disable_search: true is correct since files are explicitly provided
• Ensure CODECOV_TOKEN secret is configured with proper permissions
• The trailing comma in COVERAGE_FILES (from %p,) may need verification

Code Quality: 8/10

Solid implementation following best practices. Main concern is the missing checkout step which may cause metadata association issues in Codecov.

Overall, this is a valuable addition to the CI pipeline!

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ -0.09%	✅ ∅

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (eb0d72a)	129833	72310	55.69%
Head commit (563652a)	129833 (+0)	72188 (-122)	55.60% (-0.09%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#3308)	0	0	∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

[claude]

Pull Request Review: Add Codecov Coverage Upload

Summary

This PR adds Codecov integration to the CI pipeline alongside the existing Codacy coverage reporting. The changes are minimal and focused on the coverage-report job in the GitHub Actions workflow.

---

✅ Positive Aspects

1. SHA-pinned action: The PR correctly uses SHA-pinned GitHub Actions (codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de) following the project's security best practices.

2. Proper checkout step added: The addition of actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd at the start of the job is correct - the codecov action needs the repository context.

3. Fail-safe configuration: Using fail_ci_if_error: false ensures that Codecov upload failures won't break the CI pipeline, which is appropriate for a new integration.

4. Conditional execution: The if: success() || failure() condition ensures coverage is uploaded regardless of test results, which is valuable for tracking coverage trends even when tests fail.

5. Explicit file specification: Using disable_search: true and explicitly providing files via files: ${{ steps.coverage-files-generator.outputs.COVERAGE_FILES }} is more reliable than auto-discovery.

---

🔍 Issues & Recommendations

1. Missing empty line (minor style issue)

There's an extra blank line after the checkout step (line 452) that seems unnecessary based on the existing workflow style.

Location: .github/workflows/mvn-test.yml:452-453

Current:

- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

- name: Download unit test coverage reports

Suggested:

- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- name: Download unit test coverage reports

2. CODECOV_TOKEN secret requirement

The workflow references secrets.CODECOV_TOKEN but doesn't document whether this secret has been configured in the repository settings.

Action needed: Verify that the CODECOV_TOKEN secret is properly configured in the repository settings before merging, otherwise the upload will fail silently (which is okay due to fail_ci_if_error: false, but defeats the purpose).

3. Potential trailing spaces in files parameter

The files parameter has an extra space after the colon: files: ${{ ... }} (two spaces instead of one). While this likely works, it's inconsistent with YAML style conventions.

Location: .github/workflows/mvn-test.yml:491

Current:

files:  ${{ steps.coverage-files-generator.outputs.COVERAGE_FILES }}

Suggested:

files: ${{ steps.coverage-files-generator.outputs.COVERAGE_FILES }}

4. Consider codecov.yml configuration

While not required, adding a .codecov.yml configuration file would provide better control over:

• Coverage thresholds
• File/path exclusions
• Comment formatting on PRs
• Coverage targets per component

This is optional but recommended for production use.

---

🔒 Security Review

✅ No security concerns identified

• Action is properly SHA-pinned
• Token is correctly stored in secrets (not hardcoded)
• No sensitive data exposure risk

---

🎯 Test Coverage

⚠️ No tests required - This is a CI/CD infrastructure change that doesn't modify application code. The change will be validated automatically when the workflow runs.

---

📊 Performance Considerations

✅ Minimal performance impact

• The codecov upload runs in parallel with Codacy upload (both use if: success() || failure())
• Upload typically takes 5-15 seconds
• No impact on build or test execution time

---

✨ Overall Assessment

Recommendation: ✅ Approve with minor style fixes

This is a straightforward and well-implemented addition that:

• Follows project conventions and security practices
• Doesn't introduce risks to the CI pipeline
• Provides valuable coverage tracking via Codecov

The minor style issues (extra blank line, double space) are cosmetic and don't block approval, but cleaning them up would maintain consistency with the rest of the workflow file.

Before merging: Please confirm that the CODECOV_TOKEN secret has been added to the repository settings.

---

📝 Suggested Follow-up (Optional)

Consider adding a .codecov.yml configuration file in a future PR to:

• Define coverage targets and thresholds
• Configure PR comment behavior
• Set up component-based coverage tracking
• Exclude test/generated code from coverage calculations

---

Review completed following CLAUDE.md guidelines

[codecov]

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️