B4/rust binder impl flags#4
Open
jahnavi-MN496 wants to merge 4 commits into
Open
Conversation
# Describe the purpose of this series. The information you put here
# will be used by the project maintainer to make a decision whether
# your patches should be reviewed, and in what priority order. Please be
# very detailed and link to any relevant discussions or sites that the
# maintainer can review to better understand your proposed changes. If you
# only have a single patch in your series, the contents of the cover
# letter will be appended to the "under-the-cut" portion of the patch.
# Lines starting with # will be removed from the cover letter. You can
# use them to add notes or reminders to yourself. If you want to use
# markdown headers in your cover letter, start the line with ">#".
# You can add trailers to the cover letter. Any email addresses found in
# these trailers will be added to the addresses specified/generated
# during the b4 send stage. You can also run "b4 prep --auto-to-cc" to
# auto-populate the To: and Cc: trailers based on the code being
# modified.
Change-Id: I8375178251d97e7ad784a6ccd8c108c0d2d2b2eb
Signed-off-by: Jahnavi MN <jahnavimn@google.com>
--- b4-submit-tracking ---
# This section is used internally by b4 prep for tracking purposes.
{
"series": {
"revision": 1,
"change-id": "20260715-b4-rust_binder_impl_flags-e53b4ebca85d",
"prefixes": []
}
}
Change-Id: I4fca5149ede246c04b43b0cce94e7fd6faa996a5
Change-Id: Ifbec19f2d212483f0462c30e732908a1c73793bf
Change-Id: I7d8cd4298af651fc862896bf2a87caf6e2c3ceb4
Darksonn
reviewed
Jul 15, 2026
|
|
||
| if self.flags & old.flags & (TF_ONE_WAY | TF_UPDATE_TXN) != (TF_ONE_WAY | TF_UPDATE_TXN) { | ||
| let required = TransactionFlag::OneWay | TransactionFlag::UpdateTxn; | ||
| if !self.flags.contains_all(required) || !old.flags.contains_all(required) { |
Owner
There was a problem hiding this comment.
This is a super minor thing, but I would find it easier to read like this.
Suggested change
| if !self.flags.contains_all(required) || !old.flags.contains_all(required) { | |
| if !(self.flags.contains_all(required) && old.flags.contains_all(required)) { |
| #[inline] | ||
| pub(crate) fn is_oneway(&self) -> bool { | ||
| self.flags & TF_ONE_WAY != 0 | ||
| self.flags.contains(TransactionFlag::OneWay) |
Owner
There was a problem hiding this comment.
We check flags.contains(TransactionFlag::OneWay) super often. It might be nice to add a helper function called is_oneway() on TransactionFlags type to make these calls even shorter and easier to read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.