Skip to content

algernon 1.12.12#69272

Closed
xyproto wants to merge 2 commits into
Homebrew:masterfrom
xyproto:update-algernon.rb-1610976706
Closed

algernon 1.12.12#69272
xyproto wants to merge 2 commits into
Homebrew:masterfrom
xyproto:update-algernon.rb-1610976706

Conversation

@xyproto

@xyproto xyproto commented Jan 18, 2021

Copy link
Copy Markdown
Contributor

@BrewTestBot BrewTestBot added go Go use is a significant feature of the PR or issue no ARM bottle Formula has no ARM bottle labels Jan 18, 2021
@xyproto

xyproto commented Jan 18, 2021

Copy link
Copy Markdown
Contributor Author

I don't have an Apple M1 CPU, but in theory, Algernon should compile for Apple M1 as well now (darwin + arm64).

@carlocab carlocab added the CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. label Jan 18, 2021
carlocab
carlocab previously approved these changes Jan 18, 2021

@carlocab carlocab left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @xyproto.

@carlocab
carlocab dismissed their stale review January 18, 2021 14:18

Let's update the go build call first.

@carlocab

Copy link
Copy Markdown
Member

Actually, I think we can take this opportunity to simplify the go build call in the install block. Do you mind updating it to

system "go", "build", *std_go_args, "-mod=vendor"

?

fxcoudert
fxcoudert previously approved these changes Jan 18, 2021
@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Jan 18, 2021
@BrewTestBot

Copy link
Copy Markdown
Contributor

🤖 A scheduled task has triggered a merge.

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 18, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. go Go use is a significant feature of the PR or issue no ARM bottle Formula has no ARM bottle outdated PR was locked due to age ready to merge PR can be merged once CI is green

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants