Remove support for rope

[mjbvz]

Environment data

• VS Code version: 1.43
• Extension version (available under the Extensions sidebar): 2020.2.64397
• Jedi or Language Server? (i.e. what is "python.jediEnabled" set to; more info How to update the language server to the latest stable version #3977): tested with both. Doesn't seem to effect this

Steps to reproduce:

1. Make python file dirty
2. Then select some code and try running extract method

Expected behavior

It extracts the method

Actual behavior

A notification appears telling me to save the file. Why do I need to save? And if saving is really required for now, why don't you just save the file for me?

This current UX makes refactoring a pain

[karthiknadig]

@kimadeline First we need to know if they are using rope. We need to see if we can pass string to rope.

[kimadeline]

Yup, Extract Method uses rope for refactoring, and it performs these actions on resources pointing to files inside a project (in our case, the workspace folder).

👉 We can't pass strings to rope, we have to work with a file.

Suggestions:

• save the file automatically
• copy the code in a temp file, perform the action there, and then replace the content of the current file

[DonJayamanne]

copy the code in a temp file, perform the action there, and then replace

Considering the fact that rope has not supported Python 3 for a while, I think its time consider dropping it. However we'd need to first find out whether this is a good idea, i.e. do users use this today, does it work without any problems (I don't think so, hasn't supported 3).
@brettcannon /cc

[brettcannon]

We still get bug reports for it so some people seem to be at least attempting to use it. David said he is looking at refactoring support in Jedi.

As for whether we should just yank it now or wait I don't know without chatting with @luabud about it.