Add PHPStan and PHP CodeSniffer configuration#17
Closed
borkweb wants to merge 1 commit into
Closed
Conversation
borkweb
commented
Jul 12, 2025
borkweb
commented
Contributor
- Add phpstan.neon.dist with max level analysis
- Add phpcs.xml.dist with PSR-12 coding standards
- Configure both tools to scan src/ and tests/ directories
- Set up parallel processing and colored output for phpcs
- Add phpstan.neon.dist with max level analysis - Add phpcs.xml.dist with PSR-12 coding standards - Configure both tools to scan src/ and tests/ directories - Set up parallel processing and colored output for phpcs
This was referenced Jul 12, 2025
felixarntz
added
the
[Tool]
felixarntz
reviewed
Jul 12, 2025
felixarntz
left a comment
felixarntz
left a comment
Member
There was a problem hiding this comment.
@borkweb Thanks!
See my related comments in #16 - I guess if we merge both PRs together, it's fine to keep all the composer.json changes in the other PR, but ideally they should be in here as the other PR doesn't add this tooling.
Other than that, this PR looks good to go. Maybe add a dummy PHP file in src with just a class and minimal test code, so that we can already verify that all of this works?
Contributor
Author
|
For simplicity's sake, I'll cherry-pick this into the other PR so we can do it all in one fell swoop. (along with the dummy file) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
