Skip to content

[Issue 14013][broker] make getInternalStats method async #14047

Closed
HQebupt wants to merge 1 commit into
apache:masterfrom
HQebupt:getInternalStats
Closed

[Issue 14013][broker] make getInternalStats method async #14047
HQebupt wants to merge 1 commit into
apache:masterfrom
HQebupt:getInternalStats

Conversation

@HQebupt

@HQebupt HQebupt commented Jan 29, 2022

Copy link
Copy Markdown
Contributor

Master Issue: #14013

Motivation

See #14013

Verifying this change

Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

  • no-need-doc

@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Jan 29, 2022

@mattisonchao mattisonchao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1.
but I have two suggestions:

Remove asyncResponse from the internal method, and unified exception and result handling are performed at the controller layer, which makes the internal method purer.
Have you checked to see if there is a test for the modified method ?

@Jason918 Jason918 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please fix test failure.

@HQebupt

HQebupt commented Jan 30, 2022

Copy link
Copy Markdown
Contributor Author

/pulsarbot rerun-failure-checks

@github-actions

github-actions Bot commented Mar 2, 2022

Copy link
Copy Markdown

The pr had no activity for 30 days, mark with Stale label.

@Jason918

Jason918 commented Mar 2, 2022

Copy link
Copy Markdown
Contributor

@HQebupt Please resolve the test failure.

@HQebupt

HQebupt commented Mar 6, 2022

Copy link
Copy Markdown
Contributor Author

/pulsarbot rerun-failure-checks

@HQebupt

HQebupt commented Apr 2, 2022

Copy link
Copy Markdown
Contributor Author

/pulsarbot rerun-failure-checks

@lhotari

lhotari commented Apr 2, 2022

Copy link
Copy Markdown
Member

Please don't rerun failed checks. That won't make the tests pass since this PR contains outdated GitHub Actions workflow changes. You must rebase this PR, push new commits or merge master branch changes to it. Please check the dev mailing list for more information.

@HQebupt

HQebupt commented Apr 2, 2022

Copy link
Copy Markdown
Contributor Author

Please don't rerun failed checks. That won't make the tests pass since this PR contains outdated GitHub Actions workflow changes. You must rebase this PR, push new commits or merge master branch changes to it. Please check the dev mailing list for more information.

Got it. Thx Lari @lhotari

@github-actions

Copy link
Copy Markdown

The pr had no activity for 30 days, mark with Stale label.

@github-actions

Copy link
Copy Markdown

The pr had no activity for 30 days, mark with Stale label.

@HQebupt HQebupt closed this Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs lifecycle/stale Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants