[Broker] Make PersistentTopicsBase#terminate async#14064
Closed
RobertIndie wants to merge 5 commits into
Closed
Conversation
Motivation See apache#14013 Modification * Make PersistentTopicsBase#terminate async Signed-off-by: Zike Yang <zkyang@streamnative.io>
Signed-off-by: Zike Yang <zkyang@streamnative.io>
Member
Author
|
/pulsarbot run-failure-checks |
19 tasks
Signed-off-by: Zike Yang <zkyang@streamnative.io>
Signed-off-by: Zike Yang <zkyang@streamnative.io>
| @@ -2675,7 +2676,14 @@ public MessageId terminate( | |||
| @ApiParam(value = "Is authentication required to perform this operation") | |||
| @QueryParam("authoritative") @DefaultValue("false") boolean authoritative) { | |||
| validatePersistentTopicName(tenant, namespace, encodedTopic); | |||
Member
Author
There was a problem hiding this comment.
I think we don't need to. The exception it throws is of type RestException.
1 task
|
The pr had no activity for 30 days, mark with Stale label. |
19 tasks
|
The pr had no activity for 30 days, mark with Stale label. |
Member
Author
|
These changes have been moved to #16227 . So close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master Issue: #14013
Motivation
See #14013
Modifications
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation
no-need-doc