This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] generalize focusability in semantics#41831
Merged
auto-submit[bot] merged 3 commits intoMay 10, 2023
Merged
Conversation
mdebbar
approved these changes
May 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 10, 2023
auto-submit Bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 11, 2023
flutter-team-archive/engine@de6e130...ef771f9 2023-05-10 chris@bracken.jp [macos] Disable background colour tests (flutter-team-archive/engine#41904) 2023-05-10 yjbanov@google.com [web] generalize focusability in semantics (flutter-team-archive/engine#41831) 2023-05-10 skia-flutter-autoroll@skia.org Roll Skia from 32f4cfc2460b to 1a29bd9a0147 (12 revisions) (flutter-team-archive/engine#41905) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
…6481) flutter-team-archive/engine@de6e130...ef771f9 2023-05-10 chris@bracken.jp [macos] Disable background colour tests (flutter-team-archive/engine#41904) 2023-05-10 yjbanov@google.com [web] generalize focusability in semantics (flutter-team-archive/engine#41831) 2023-05-10 skia-flutter-autoroll@skia.org Roll Skia from 32f4cfc2460b to 1a29bd9a0147 (12 revisions) (flutter-team-archive/engine#41905) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce 2 new classes for a11y focus management:
AccessibilityFocusManager: a generic class that attaches "focus" and "blur" event handlers, and forwards the events to the framework asSemanticsAction.didGainAccessibilityFocusandSemanticsAction.didLoseAccessibilityFocusrespectively. Provides thechangeFocusmethod for the framework to move a11y focus to the target element.Focusable: a role manager that provides generic focus management functionality toSemanticsObjects that don't need anything special.Rewrites focus management using the above two classes as follows:
Focusablerole (all custom focus stuff inTappablewas removed and delegated toFocusable).Incrementableuses a custom<input>internally and so it cannot use theFocusablerole. Instead, it usesAccessibilityFocusManagerto manage the focus on the<input>element.Behavioral changes:
autofocuson checkbox doesn't have an effect in accessibility mode flutter/flutter#118737, but more generally fixes all nodes that use theisFocusableandhasFocusbits.Tappableonly partially implemented focusability (e.g. it didn't generate the respectiveSemanticsActionevents). Now by delegating toFocusable, it will inherit all the functionality.IncrementableandCheckable(checkboxes, radios, switches) get focus management features for the first time.TextFieldis left alone for now as focus and on-screen keyboard interact with each other in non-obvious ways.