Skip to content

acme: add support for external account bindings#109

Open
munnerz wants to merge 3 commits into
golang:masterfrom
munnerz:crypto-acme-eab
Open

acme: add support for external account bindings#109
munnerz wants to merge 3 commits into
golang:masterfrom
munnerz:crypto-acme-eab

Conversation

@munnerz

@munnerz munnerz commented Dec 3, 2019

Copy link
Copy Markdown
Contributor

This adds support for ExternalAccountBindings into the crypto/acme client.

It is based on section 7.3.4 of RFC8555: https://tools.ietf.org/html/rfc8555#section-7.3.4

I have tested this against Pebble with support for EABs letsencrypt/pebble#288 as well as another CAs ACME implementation that requires EAB.

/cc @JoshVanL

@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: b417403) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/209678 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/209678.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: 79ac0b8) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/209678 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: e184477) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/209678 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: f3a5c70) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/209678 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/209678.
After addressing review feedback, remember to publish your drafts!

@jdkasten

Copy link
Copy Markdown

Hi munnerz@,
I saw your work here and was interested in getting it pushed through. I realized that it needed an API proposal before it would be considered for review. I made the proposal at golang/go#41430 which was accepted with minor modifications. I built upon your work and sent out #162, but it looks like the googlebot wants an additional consent.

Would you mind adding a @googlebot I consent. comment to PR #162?

Thanks for all of the work that you put in on this project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants