acme: add support for external account bindings#109
Conversation
|
This PR (HEAD: b417403) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/crypto/+/209678 to see it. Tip: You can toggle comments from me using the |
|
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/209678. |
b417403 to
79ac0b8
Compare
|
This PR (HEAD: 79ac0b8) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/crypto/+/209678 to see it. Tip: You can toggle comments from me using the |
79ac0b8 to
e184477
Compare
|
This PR (HEAD: e184477) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/crypto/+/209678 to see it. Tip: You can toggle comments from me using the |
Merge 'master' into EAB changes
|
This PR (HEAD: f3a5c70) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/crypto/+/209678 to see it. Tip: You can toggle comments from me using the |
|
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/209678. |
|
Hi munnerz@, Would you mind adding a Thanks for all of the work that you put in on this project! |
This adds support for ExternalAccountBindings into the
crypto/acmeclient.It is based on section 7.3.4 of RFC8555: https://tools.ietf.org/html/rfc8555#section-7.3.4
I have tested this against Pebble with support for EABs letsencrypt/pebble#288 as well as another CAs ACME implementation that requires EAB.
/cc @JoshVanL