Closed
[WIP] Refactor validation engine infrastructure for Laravel compatibility#1398
Conversation
1 task
- Thread 1: Return parse errors from NewDataBagFromRequest instead of swallowing them - Thread 2: Recursively normalize nested structs/slices/maps in structToMap - Thread 3: Merge wildcard-expanded rules instead of overwriting, drop unmatched wildcards - Thread 4: Run exclude rules in pre-pass before validation rules - Thread 5: Return internal error for unknown rules instead of treating as validation failure - Thread 10: Use reflect for typed slice/map emptiness check in isValueEmpty - Thread 11: Add runtime value kind fallback for numeric type detection - Thread 13: Use DataBag.Set for proper nested path handling in Bind Co-authored-by: devhaozi <115467771+devhaozi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NewDataBagFromRequest- return parse errors instead of swallowing themstructToMapto recursively normalize nested structs/slices/mapsexpandWildcardRulesto merge rules instead of overwriting, drop unmatched wildcardsvalidateFieldisValueEmptyfor typed slices/mapsgetAttributeTypeBind()with DataBag.Set for proper nested path handling🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.