Fix incorrect error instructing to "pip install sklearn"#436
Open
dongreenberg wants to merge 1 commit into
Open
Fix incorrect error instructing to "pip install sklearn"#436dongreenberg wants to merge 1 commit into
dongreenberg wants to merge 1 commit into
Conversation
Fixes huggingface#394, and what I imagine is a frequent trip-up for people who forget that the correct pypi package name is "scikit-learn".
lvwerra
approved these changes
Apr 13, 2023
lvwerra
left a comment
lvwerra
left a comment
Member
There was a problem hiding this comment.
Thanks for fixing this, looks good!
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Member
|
Can you run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #394, and what I imagine is a frequent trip-up for people who forget that the correct pypi package name is "scikit-learn."