[5.3] php-serialized value object attributes for Eloquent Model#13511
Closed
halaei wants to merge 1 commit into
Closed
[5.3] php-serialized value object attributes for Eloquent Model#13511halaei wants to merge 1 commit into
halaei wants to merge 1 commit into
Conversation
…ng with casts) supporting inheritance
Contributor
Author
|
It is possible to do the same thing with accessors and mutators by the way! So maybe no need for this PR, except it may be more convenient. |
Member
|
I think that's the same as #13315 |
Contributor
Author
|
By the way, have you seen this test? Someone might think it is not OK! public function testModelDateAttributesAreImmutable()
{
$model = new EloquentModelCastingStub();
$model->setDateFormat('Y-m-d H:i:s');
$model->dateAttribute = '2016-01-03 10:11:12';
$this->assertNotSame($model->dateAttribute, $model->dateAttribute);
$model->dateAttribute->second = 0;
$this->assertEquals(12, $model->dateAttribute->second);
$model['dateAttribute'] = '2016-01-03 10:11:12';
$this->assertNotSame($model['dateAttribute'], $model['dateAttribute']);
$model['dateAttribute']->second = 0;
$this->assertEquals(12, $model['dateAttribute']->second);
} |
Contributor
Author
|
This PR is based on php serialization and support inheritance as well! I guess it is not 100% similar to #13315 |
Member
|
Going to hold off on this in the core. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...(implementing with casts) supporting inheritance
Sample usecase: chat states for Telegram Bots
The pseudo code of main Telegram update handler function does the following:
What do you think?