Skip to content

remove "===" suffix of base32 encoded secret#1

Merged
lepture merged 1 commit into
authlib:masterfrom
sublee:master
Jul 4, 2013
Merged

remove "===" suffix of base32 encoded secret#1
lepture merged 1 commit into
authlib:masterfrom
sublee:master

Conversation

@sublee

@sublee sublee commented Jul 4, 2013

Copy link
Copy Markdown
Contributor

Hi Hsiaoming,

I patched OtpAuth.to_google to remove "===" suffix of base32 encoded secret. Because my Google Authenticator failed to read a QRCode when "===" exists.

Please confirm my pull request and update the version.

@lepture

lepture commented Jul 4, 2013

Copy link
Copy Markdown
Member

@sublee Any documentation on Google striped === ?

@lepture

lepture commented Jul 4, 2013

Copy link
Copy Markdown
Member

http://tools.ietf.org/html/rfc3548


                   Table 1: The Base 64 Alphabet

      Value Encoding  Value Encoding  Value Encoding  Value Encoding
          0 A            17 R            34 i            51 z
          1 B            18 S            35 j            52 0
          2 C            19 T            36 k            53 1
          3 D            20 U            37 l            54 2
          4 E            21 V            38 m            55 3
          5 F            22 W            39 n            56 4
          6 G            23 X            40 o            57 5
          7 H            24 Y            41 p            58 6
          8 I            25 Z            42 q            59 7
          9 J            26 a            43 r            60 8
         10 K            27 b            44 s            61 9
         11 L            28 c            45 t            62 +
         12 M            29 d            46 u            63 /
         13 N            30 e            47 v
         14 O            31 f            48 w         (pad) =
         15 P            32 g            49 x
         16 Q            33 h            50 y

I will have a try on Google

@sublee

sublee commented Jul 4, 2013

Copy link
Copy Markdown
Contributor Author

No I couldn't find. I'll wait you to test with === in your Google Authenticator.

@lepture

lepture commented Jul 4, 2013

Copy link
Copy Markdown
Member

@sublee Yes, you are right, we need to remove the pad string for Google.

@sublee

sublee commented Jul 4, 2013

Copy link
Copy Markdown
Contributor Author

Thanks to test it. Would you accept this pull request?

lepture added a commit that referenced this pull request Jul 4, 2013
remove "===" suffix of base32 encoded secret
@lepture
lepture merged commit a69bf66 into authlib:master Jul 4, 2013
lepture added a commit that referenced this pull request Jul 4, 2013
@lepture

lepture commented Jul 4, 2013

Copy link
Copy Markdown
Member

@sublee 0.1.1 is released.

@sublee

sublee commented Jul 4, 2013

Copy link
Copy Markdown
Contributor Author

Cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants