remove "===" suffix of base32 encoded secret#1
Merged
Conversation
Member
|
@sublee Any documentation on Google striped |
Member
|
http://tools.ietf.org/html/rfc3548 I will have a try on Google |
Contributor
Author
|
No I couldn't find. I'll wait you to test with === in your Google Authenticator. |
Member
|
@sublee Yes, you are right, we need to remove the pad string for Google. |
Contributor
Author
|
Thanks to test it. Would you accept this pull request? |
lepture
added a commit
that referenced
this pull request
Jul 4, 2013
remove "===" suffix of base32 encoded secret
lepture
added a commit
that referenced
this pull request
Jul 4, 2013
Member
|
@sublee 0.1.1 is released. |
Contributor
Author
|
Cool! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Hsiaoming,
I patched
OtpAuth.to_googleto remove "===" suffix of base32 encoded secret. Because my Google Authenticator failed to read a QRCode when "===" exists.Please confirm my pull request and update the version.