Change disco pane preview in admin tools to match Firefox's design

[diox]

When https://bugzilla.mozilla.org/show_bug.cgi?id=1540173 lands we should change the "preview" for disco pane items in the admin. It currently follows AMO's disco pane design (roughly), it should follow Firefox's design once it's up.

See also #6546

[Rob--W]

The patches have landed in Firefox Nightly (68.0a1 buildID 20190509214305).

To use it, set the extensions.htmlaboutaddons.discover.enabled pref to true.

• Main bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1546248
• Appearance of star ratings: https://bugzilla.mozilla.org/show_bug.cgi?id=1542262
• Notes on screenshot size: https://bugzilla.mozilla.org/show_bug.cgi?id=1546123

[stale]

This issue has been automatically marked as stale because it has not had recent activity. If you think this bug should stay open, please comment on the issue with further details. Thank you for your contributions.

[eviljeff]

@diox can you explain what needs to be changed? I don't see the difference between what's shown in the admin and in Firefox's discovery pane (other than a line return between the addon's name and "by Joe User", which seems a little trivial ?)

[diox]

The key visual difference is the trivial bit you noticed, yes. But under the hood, Firefox does not use the heading and description properties of our API, which returns HTML. Instead, if uses description_text and builds its own title from the add-on name and authors returned (unless it uses heading but strips everything after the first <span> ? I haven't checked).

So, to fully clean this up, we need to match this behavior, removing our support for HTML variants of the heading & description, probably remove custom heading completely in fact if Firefox is not using that.

[eviljeff]

resurrecting this now we've deleted (#13735) the frontend discopane app that consumed the old html properties from the api.

[eviljeff]

@Rob--W can you confirm/point to what information is consumed in Firefox from the api endpoint https://addons-server.readthedocs.io/en/latest/topics/api/discovery.html ?

[Rob--W]

The consumer of the API in Firefox is here:

• https://searchfox.org/mozilla-central/rev/c409dd9235c133ab41eba635f906aa16e050c197/toolkit/mozapps/extensions/content/aboutaddons.js#569-599
• https://searchfox.org/mozilla-central/rev/c409dd9235c133ab41eba635f906aa16e050c197/toolkit/mozapps/extensions/internal/AddonRepository.jsm#580-663

The unit tests in Firefox are designed to support the use case of refactoring the API response.
If you are interested in running the test yourself, you can clone the repository (with git or hg) and run the test as shown below. Feel free to ask me to run the test if you want it to be double-checked, it isn't that much of an effort.

$ cd path/to/repo/mozilla-central
$ wget https://addons.allizom.org/api/v4/discovery/?lang=en-US -O toolkit/mozapps/extensions/test/browser/discovery/api_response.json
$ ./mach bootstrap --no-system
(choose Artifact build for desktop)
$ ./mach build
$ ./mach test toolkit/mozapps/extensions/test/browser/browser_html_discover_view.js --verbose --log-mach-verbose

[eviljeff]

thanks Rob.
So from looking at the source, it uses heading_text and description_text; AMO's discovery api currently returns heading, description, description_text - i.e. we can safely drop heading and description - note also it never returns heading_text.

Assuming that we don't want to suddenly start returning a html-less version of heading as heading_text over a year later, we can drop the custom heading from the models/db/translations too.