Add is_recommended to autocomplete results

[bobsilverberg]

Blocks #13194

Please update the Autocomplete endpoint in order to expose is_recommended.

[AlexandraMoga]

The is _recommended parameter is exposed now by the Autocomplete api.

@eviljeff I don't understand why is_recommended returns null and not false for most of the extensions. Here is an example:

https://addons-dev.allizom.org/api/v4/addons/autocomplete/?type=extension

Response

{
    "results": [
        {
            "id": 494830,
            "icon_url": "https://addons-dev-cdn.allizom.org/static/img/addon-icons/default-64.png",
            "is_recommended": false,
            "name": {
                "en-US": "Multi-Account Containers",
                "it": "Contenitori multi-acconto"
            },
            "type": "extension",
            "url": "https://addons-dev.allizom.org/en-US/firefox/addon/multi-account-containers/"
        },
        {
            "id": 287841,
            "icon_url": "https://addons-dev-cdn.allizom.org/user-media/addon_icons/287/287841-64.png?modified=1541602472",
            "is_recommended": true,
            "name": {
                "en-US": "Awesome Screenshot Plus - Capture, Annotate & More",
                "es": "Impresionante captura de pantalla Plus:"
            },
            "type": "extension",
            "url": "https://addons-dev.allizom.org/en-US/firefox/addon/awesome-screenshot-plus-/"
        },
        {
            "id": 527025,
            "icon_url": "https://addons-dev-cdn.allizom.org/static/img/addon-icons/default-64.png",
            "is_recommended": null,
            "name": {
                "de": "anonymoX",
                "en-US": "anonymoXVictor"
            },
            "type": "extension",
            "url": "https://addons-dev.allizom.org/en-US/firefox/addon/anonymoxvictor/"
        },
        {
            "id": 492073,
            "icon_url": "https://addons-dev-cdn.allizom.org/static/img/addon-icons/default-64.png",
            "is_recommended": null,
            "name": {
                "en-US": "updateCheckMDLnoID"
            },
            "type": "extension",
            "url": "https://addons-dev.allizom.org/en-US/firefox/addon/updatecheckmdlnoid/"
        },
        {
            "id": 492126,
            "icon_url": "https://addons-dev-cdn.allizom.org/static/img/addon-icons/default-64.png",
            "is_recommended": null,
            "name": {
                "en-US": "mdlCrxUpdateCheck03"
            },
            "type": "extension",
            "url": "https://addons-dev.allizom.org/en-US/firefox/addon/mdlcrxupdatecheck03/"
        },
        {
            "id": 494560,
            "icon_url": "https://addons-dev-cdn.allizom.org/static/img/addon-icons/default-64.png",
            "is_recommended": true,
            "name": {
                "en-US": "WebExtensionsPermissions"
            },
            "type": "extension",
            "url": "https://addons-dev.allizom.org/en-US/firefox/addon/webextensionspermissions/"
        },
        {
            "id": 502888,
            "icon_url": "https://addons-dev-cdn.allizom.org/static/img/addon-icons/default-64.png",
            "is_recommended": null,
            "name": {
                "en-US": "Release01.22.2019"
            },
            "type": "extension",
            "url": "https://addons-dev.allizom.org/en-US/firefox/addon/release01-22-2019/"
        },
        {
            "id": 325576,
            "icon_url": "https://addons-dev-cdn.allizom.org/user-media/addon_icons/325/325576-64.png?modified=1557834314",
            "is_recommended": true,
            "name": {
                "de": "anonymoX",
                "en-US": "anonymoX"
            },
            "type": "extension",
            "url": "https://addons-dev.allizom.org/en-US/firefox/addon/anonymox/"
        },
        {
            "id": 491738,
            "icon_url": "https://addons-dev-cdn.allizom.org/user-media/addon_icons/491/491738-64.png?modified=1542708510",
            "is_recommended": true,
            "name": {
                "en-US": "HYFY Screen Recorder"
            },
            "type": "extension",
            "url": "https://addons-dev.allizom.org/en-US/firefox/addon/hyfy-screen-recorder/"
        },
        {
            "id": 5890,
            "icon_url": "https://addons-dev-cdn.allizom.org/user-media/addon_icons/5/5890-64.png?modified=1543078416",
            "is_recommended": null,
            "name": {
                "en-US": "Tree Style Tab",
                "es": "Tree Style Tab (Pestañas estilo árbol)",
                "ja": "ツリー型タブ (Tree Style Tab)",
                "ru": "Tree Style Tab (Древовидный стиль вкладок)"
            },
            "type": "extension",
            "url": "https://addons-dev.allizom.org/en-US/firefox/addon/tree-style-tab/"
        }
    ]
}

If I'm comparing with the details api, is_recommended returns false for those extensions.

[eviljeff]

it's null for all the add-ons that haven't been reindexed in a while (null is the default) - it'll be false` after the add-on is reindexed - or we force a full reindex. I'll run a reindex on -dev now.