-
Notifications
You must be signed in to change notification settings - Fork 77
Config to set /ignore and /notify #344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
2b1c86a
Config to set /ignore and /notify
trevarj baf6a2b
Added /join cmd parameters
trevarj 8c77758
Allow add_client_err_msg to create tab
trevarj 07d57f1
Remove unused Clone
trevarj cf98be0
Fix config example for join field
trevarj c101f6b
Revert unrelated refactoring
trevarj 55f5058
Use [..] syntax in config arg examples
trevarj baec639
Iterator simplifications
trevarj 79dcbe3
Revert unrelated visibility change
trevarj 6c4eb09
Large refactor / cleanup. Needs testing
trevarj 43d4424
some fixes to get notifier and /reload working
trevarj 123d2fe
formatting
trevarj c0c0e73
fix test error
trevarj 7a4a09e
Changes based on PR conversation
trevarj f673fd8
Add hacky logic for toggling tab config
trevarj 1c60171
revert another formatting change
trevarj a1e6d1d
Merge branch 'master' into default-ignore-notify
trevarj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a big deal probably, but I wonder if we should expect user to get this right instead of inserting a
#for them. The problem is channel names can contain multiple#s, not just one, but we assume one here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is something I noticed other clients do, so I added it if there is no
#. It seems like a nicer UX, but we don't need to have it.