Fix Enter navigation in Help find#14380
Closed
PGupta-Git wants to merge 1 commit into
Closed
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
Author
Member
|
Thank you for this PR, @PGupta-Git! 🙌 We will need to apply your commits to a new, non-fork PR because of the problems outlined in #6628. |
Contributor
Author
Thank you so much. Please let me know if I need to do anything from my end. |
Contributor
|
Thank you for this PR, @PGupta-Git — it fixes the problem! I've carried your changes over into #14444, where I also added find-wraparound, so that find now behaves the way it does in a standard browser session. Much appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12921
This PR handles plain Enter in the shared webview find widget so pressing Enter advances to the next webview match and Shift+Enter moves to the previous match. It also removes the Help pane's post-find focus message so the Find input keeps focus after navigation, matching the Help accessibility text and normal find behavior.
Release Notes
New Features
Bug Fixes
Validation Steps
@:help @:search
plot()with?plot.title.Demo
Screencast.From.2026-06-19.15-07-43.mp4
Automated validation run locally:
npm run compile-check-ts-nativenpx vitest run src/vs/workbench/contrib/webview/test/browser/webviewFindWidget.vitest.ts src/vs/workbench/contrib/positronHelp/test/browser/helpEntry.vitest.tsnpx eslint --max-warnings 0 src/vs/workbench/contrib/webview/browser/webviewFindWidget.ts src/vs/workbench/contrib/webview/test/browser/webviewFindWidget.vitest.ts src/vs/workbench/contrib/positronHelp/browser/helpEntry.ts src/vs/workbench/contrib/positronHelp/test/browser/helpEntry.vitest.tsnode --experimental-strip-types build/hygiene.ts src/vs/workbench/contrib/webview/browser/webviewFindWidget.ts src/vs/workbench/contrib/webview/test/browser/webviewFindWidget.vitest.ts src/vs/workbench/contrib/positronHelp/browser/helpEntry.ts src/vs/workbench/contrib/positronHelp/browser/resources/welcome.html src/vs/workbench/contrib/positronHelp/test/browser/helpEntry.vitest.ts