Skip to content

Fix Enter navigation in Help find#14380

Closed
PGupta-Git wants to merge 1 commit into
posit-dev:mainfrom
PGupta-Git:fix-help-find-enter-focus
Closed

Fix Enter navigation in Help find#14380
PGupta-Git wants to merge 1 commit into
posit-dev:mainfrom
PGupta-Git:fix-help-find-enter-focus

Conversation

@PGupta-Git

@PGupta-Git PGupta-Git commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Fixes #12921

This PR handles plain Enter in the shared webview find widget so pressing Enter advances to the next webview match and Shift+Enter moves to the previous match. It also removes the Help pane's post-find focus message so the Find input keeps focus after navigation, matching the Help accessibility text and normal find behavior.

Release Notes

New Features

  • N/A

Bug Fixes

Validation Steps

@:help @:search

  1. Open help for plot() with ?plot.
  2. Search for the word title.
  3. Press Enter repeatedly and verify the Help pane advances through matches while focus stays in the Find input.
  4. Press Shift+Enter and verify the Help pane moves to the previous match.

Demo

Screencast.From.2026-06-19.15-07-43.mp4

Automated validation run locally:

  • npm run compile-check-ts-native
  • npx vitest run src/vs/workbench/contrib/webview/test/browser/webviewFindWidget.vitest.ts src/vs/workbench/contrib/positronHelp/test/browser/helpEntry.vitest.ts
  • npx eslint --max-warnings 0 src/vs/workbench/contrib/webview/browser/webviewFindWidget.ts src/vs/workbench/contrib/webview/test/browser/webviewFindWidget.vitest.ts src/vs/workbench/contrib/positronHelp/browser/helpEntry.ts src/vs/workbench/contrib/positronHelp/test/browser/helpEntry.vitest.ts
  • node --experimental-strip-types build/hygiene.ts src/vs/workbench/contrib/webview/browser/webviewFindWidget.ts src/vs/workbench/contrib/webview/test/browser/webviewFindWidget.vitest.ts src/vs/workbench/contrib/positronHelp/browser/helpEntry.ts src/vs/workbench/contrib/positronHelp/browser/resources/welcome.html src/vs/workbench/contrib/positronHelp/test/browser/helpEntry.vitest.ts

@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@PGupta-Git

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@PGupta-Git

PGupta-Git commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

Hi @jmcphers and @seeM — this is my first contribution to Positron.

Could a maintainer please approve CI for this fork PR so the checks can run?
Happy to make any changes needed during review. Thanks.

@juliasilge
juliasilge requested a review from softwarenerd June 22, 2026 13:22
@juliasilge

Copy link
Copy Markdown
Member

Thank you for this PR, @PGupta-Git! 🙌 We will need to apply your commits to a new, non-fork PR because of the problems outlined in #6628.

@PGupta-Git

Copy link
Copy Markdown
Contributor Author

Thank you for this PR, @PGupta-Git! 🙌 We will need to apply your commits to a new, non-fork PR because of the problems outlined in #6628.

Thank you so much. Please let me know if I need to do anything from my end.

@softwarenerd

Copy link
Copy Markdown
Contributor

Thank you for this PR, @PGupta-Git — it fixes the problem! I've carried your changes over into #14444, where I also added find-wraparound, so that find now behaves the way it does in a standard browser session.

Much appreciated!

@github-actions github-actions Bot locked and limited conversation to collaborators Jun 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In Help's search, clicking enter should have the same behavior as down arrow

3 participants