bpo-33919: Expose hash_seed and use_hash_seed in sys.hash_info#7867
Closed
warsaw wants to merge 1 commit into
Closed
bpo-33919: Expose hash_seed and use_hash_seed in sys.hash_info#7867warsaw wants to merge 1 commit into
warsaw wants to merge 1 commit into
Conversation
vstinner
requested changes
Jun 23, 2018
| +------------------------+-----------------------------------------------+ | ||
| | :const:`use_hash_seed` | Whether to use :envvar:`PYTHONHASHSEED` | | ||
| +------------------------+-----------------------------------------------+ | ||
| | :const:`hash_seed` | The value from :envvar:`PYTHONHASHSEED` | |
Member
There was a problem hiding this comment.
At the C level, we need two fields, since it's not possible to distinguish "value set" to "value unset". But at the Python level, we can use None when the hash seed is unset.
Member
There was a problem hiding this comment.
It seems like the seed is always in the range [0; 4294967295], _Py_ReadHashSeed:
if (*endptr != '\0'
|| seed > 4294967295UL
|| (errno == ERANGE && seed == ULONG_MAX))
{
return -1;
}
It may be worth to document the value range.
|
When you're done making the requested changes, leave the comment: |
Member
Author
|
I wonder if it's worth pursuing this PR if all it's going to do is expose |
Member
Author
|
Discarding for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue33919