Fix automatic dark mode#2441
Closed
atjn wants to merge 1 commit into
Closed
Conversation
Contributor
|
I'm going to close as I believe this will be resolved by #2454. Thanks, though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic dark mode (in CSS) was implemented in #1069, then broken in #1641 because it moved the
no-jsclass to a different element. This PR restores the functionality. It also implements #2134 properly.I also noticed that the original implementation depends on the
lightclass to be set, which it is not if a different default theme has been chosen. I have also fixed this.Closes #2440