Fix line-height for footnote-reference#2443
Closed
dhroovsrivastava11 wants to merge 4 commits into
Closed
Conversation
…ence, removing inheritance of line height from parent class
notriddle
approved these changes
Oct 23, 2024
| } | ||
|
|
||
| .footnote-reference{ | ||
| line-height: 0; |
Contributor
There was a problem hiding this comment.
As far as I understand the standard, this does what you want because a line box's final height is the maximum of the required line-height of all the inline fragment boxes within it. This means, if you set the line-height of something to 0, that element will have no effect on the height of the line.
It's fine, as long as the footnote-reference is never alone on a line. That would be bad typography anyway.
GitHub and rustdoc's CSS both do the exact same thing. You might want to apply this style to all superscripts, not just footnote references.
https://github.com/necolas/normalize.css/blob/master/normalize.css#L128
…t footnote-references.
Ignoring line-height for superscripts
Contributor
|
What just happened? This didn't get merged, did it? |
Contributor
|
I'm not sure. I reposted this at #2465. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISSUE
#2437 Footnote reference adding some extra vertical space to the line
FIX
Changed general.css file to include custom styling for footnote reference, removing inheritance of line height from parent class.
Tested for various different browsers. (Chrome, Firefox, mobile chrome, mobile firefox)
Before
After