[6.x] Make the whole radio/checkbox item clickable#14821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes the entire radio and checkbox item — including the padding and empty space around the control and label — clickable, rather than only the control and label text.
Previously the clickable area was limited to the Reka control (
CheckboxRoot/RadioGroupItem) and the<label>wrapping the label text. This meant clicking the surrounding padding of a chip (or the description) did nothing.This PR fixes it by stretching the inner
<label>'s hit-area across the whole item using an absolutely-positionedbeforepseudo-element (before:absolute before:inset-0), with the container maderelativeto anchor it. The label keeps itsfor/idassociation to the control, so clicks anywhere in the item forward a single activation to the checkbox/radio.This PR also tidies up the radio item's accessibility by giving the description an
idand wiring it to the control viaaria-describedby, matching the checkbox component.