Fix for Postgres 12

[mikebski]

https://www.postgresql.org/docs/8.3/catalog-pg-attrdef.html

According to this page, the fix in this PR should work from PG 8.3 on.

[mikebski]

This fixes https://sourceforge.net/p/adminer/bugs-and-features/719/

[Hell4Ge]

When will this be merged into official docker image?

[stiko]

Any updates on this?

[fireartist]

Can confirm that commit 717d9e6 allows me to browse tables on postgres 12 (fedora 30)

[tinyoverflow]

I would like to see this merged. When will it be merged?

[salacr]

I can also confirm that this patch works, we didn't find any issue with that

[mikebski]

Hi @vrana - any idea when you can merge/release this? It would be nice to have this get to the downstream docker stuff I'm using...

[renderpci]

HI mikebski, I try your patch for PostgreSQL 12 but don't wort for me in Adminer 4.7.4. I fix it using this in the line has change (note var $Dd instead $identity_column):

foreach (get_rows("SELECT a.attname AS field, format_type(a.atttypid, a.atttypmod) AS full_type, pg_get_expr(d.adbin, d.adrelid) AS default, a.attnotnull::int, col_description(c.oid, a.attnum) AS comment, $Dd AS identity

[mikebski]

@renderpci - How did you patch it? If you just pasted this in to the compiled file, the variable name looks like it's different because it is minified. In the uncompiled source, the variable is $identity_column

[renderpci]

@mikebski - Yes, we prove it in the compiled file, we don't have Adminer dev version installed...

[vrana]

Merged, thanks.