Skip to content

feat: [#358] Update tests, completed finally#952

Merged
hwbrzzl merged 2 commits into
masterfrom
bowen/#358-22
Mar 9, 2025
Merged

feat: [#358] Update tests, completed finally#952
hwbrzzl merged 2 commits into
masterfrom
bowen/#358-22

Conversation

@hwbrzzl

@hwbrzzl hwbrzzl commented Mar 9, 2025

Copy link
Copy Markdown
Contributor

📑 Description

Closes goravel/goravel#358

This pull request includes updates to the tests/db_test.go file and the tests/go.mod file to improve the database testing suite and update dependencies.

Improvements to database testing suite:

  • tests/db_test.go: Moved the loop iterating over s.queries inside the Test_DB_Select_Update_Delete function to ensure the correct order of operations for different database drivers.

Dependency updates:

  • tests/go.mod: Updated the versions of database driver dependencies (mysql, postgres, sqlite, sqlserver) to their latest versions to ensure compatibility and leverage any improvements or bug fixes.

✅ Checks

  • Added test cases for my code

Copilot AI review requested due to automatic review settings March 9, 2025 09:45
@hwbrzzl
hwbrzzl requested a review from a team as a code owner March 9, 2025 09:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR updates the database testing suite and dependency versions for improved testing and compatibility.

  • Moves the loop over s.queries inside the Test_DB_Select_Update_Delete function for proper ordering
  • Updates dependency versions in tests/go.mod for database drivers

Reviewed Changes

File Description
tests/db_test.go Moved the loop iterating over s.queries to ensure proper execution order

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comment thread tests/db_test.go
@codecov

codecov Bot commented Mar 9, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.15%. Comparing base (0d45fdd) to head (158ec55).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #952   +/-   ##
=======================================
  Coverage   69.15%   69.15%           
=======================================
  Files         157      157           
  Lines       10526    10526           
=======================================
  Hits         7279     7279           
  Misses       2913     2913           
  Partials      334      334           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hwbrzzl
hwbrzzl merged commit 7bb7de2 into master Mar 9, 2025
@hwbrzzl
hwbrzzl deleted the bowen/#358-22 branch March 9, 2025 09:55
almas-x pushed a commit that referenced this pull request Mar 12, 2025
* feat: [#358] Update tests, completed finally

* update mod
almas-x pushed a commit that referenced this pull request Mar 18, 2025
* feat: [#358] Update tests, completed finally

* update mod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ [Feature] Add facades.DB, to provider an original sql flow

2 participants