fix: [#615] Request InputArray not working for JSON array#970
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #970 +/- ##
=======================================
Coverage 69.21% 69.21%
=======================================
Files 160 160
Lines 10736 10736
=======================================
Hits 7431 7431
Misses 2969 2969
Partials 336 336 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
This PR introduces a breaking change to the InputMap function: Before: InputMap(key string, defaultValue ...map[string]string) map[string]stringAfter: InputMap(key string, defaultValue ...map[string]any) map[string]any |
Contributor
|
Yes, I found that, will introduce this in the upgrade document. |
u-wlkjyy
added a commit
to u-wlkjyy/framework
that referenced
this pull request
Jun 18, 2026
- Add WithoutMiddleware method to Router interface for group-level exclusion - Regenerate mocks via go tool mockery - This enables Route.WithoutMiddleware(...).Group(...) style similar to Laravel
u-wlkjyy
added a commit
to u-wlkjyy/framework
that referenced
this pull request
Jun 19, 2026
Per review: the field is unnecessary since Info has no Middleware field either. Middleware exclusion is a driver implementation detail.
u-wlkjyy
added a commit
to u-wlkjyy/framework
that referenced
this pull request
Jun 19, 2026
Per maintainer feedback: the field's purpose is understood and it can be kept.
u-wlkjyy
added a commit
to u-wlkjyy/framework
that referenced
this pull request
Jun 21, 2026
- Add ExcludedMiddleware field to contracts/http.Info - Add WithoutMiddleware method to contracts/route.Action interface This allows routes to exclude specific middleware, similar to Laravel's withoutMiddleware() method. Useful for webhook endpoints, public APIs, and routes that need to bypass auth/throttling from protected groups.
u-wlkjyy
added a commit
to u-wlkjyy/framework
that referenced
this pull request
Jun 21, 2026
- Add WithoutMiddleware method to Router interface for group-level exclusion - Regenerate mocks via go tool mockery - This enables Route.WithoutMiddleware(...).Group(...) style similar to Laravel
u-wlkjyy
added a commit
to u-wlkjyy/framework
that referenced
this pull request
Jun 21, 2026
Per review: the field is unnecessary since Info has no Middleware field either. Middleware exclusion is a driver implementation detail.
u-wlkjyy
added a commit
to u-wlkjyy/framework
that referenced
this pull request
Jun 21, 2026
Per maintainer feedback: the field's purpose is understood and it can be kept.
hwbrzzl
pushed a commit
that referenced
this pull request
Jun 27, 2026
* feat: [#970] support withoutMiddleware similar to Laravel - Add ExcludedMiddleware field to contracts/http.Info - Add WithoutMiddleware method to contracts/route.Action interface This allows routes to exclude specific middleware, similar to Laravel's withoutMiddleware() method. Useful for webhook endpoints, public APIs, and routes that need to bypass auth/throttling from protected groups. * feat: [#970] add WithoutMiddleware to Router interface - Add WithoutMiddleware method to Router interface for group-level exclusion - Regenerate mocks via go tool mockery - This enables Route.WithoutMiddleware(...).Group(...) style similar to Laravel * refactor: [#970] drop ExcludedMiddleware from Info Per review: the field is unnecessary since Info has no Middleware field either. Middleware exclusion is a driver implementation detail. * revert: [#970] restore ExcludedMiddleware in Info Per maintainer feedback: the field's purpose is understood and it can be kept.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
Closes goravel/goravel#615
✅ Checks