Skip to content

chore: fix lint warning about useEffect#38285

Merged
Skn0tt merged 1 commit into
microsoft:mainfrom
Skn0tt:fix-lint
Nov 20, 2025
Merged

chore: fix lint warning about useEffect#38285
Skn0tt merged 1 commit into
microsoft:mainfrom
Skn0tt:fix-lint

Conversation

@Skn0tt

@Skn0tt Skn0tt commented Nov 20, 2025

Copy link
Copy Markdown
Member
packages/html-reporter/src/headerView.tsx
  56:6  warning  React Hook React.useEffect has a missing dependency: 'searchParams'. Either include it or remove the dependency array                           react-hooks/exhaustive-deps
  56:7  warning  React Hook React.useEffect has a complex expression in the dependency array. Extract it to a separate variable so it can be statically checked  react-hooks/exhaustive-deps

@Skn0tt Skn0tt self-assigned this Nov 20, 2025
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

2432 passed, 116 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

3 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node18`
⚠️ [firefox-page] › page/page-emulate-media.spec.ts:144 › should keep reduced motion and color emulation after reload `@firefox-ubuntu-22.04-node18`
⚠️ [playwright-test] › ui-mode-test-attachments.spec.ts:21 › should contain text attachment `@windows-latest-node18-2`

40276 passed, 787 skipped


Merge workflow run.

@Skn0tt
Skn0tt merged commit 3756978 into microsoft:main Nov 20, 2025
34 checks passed
jchip pushed a commit to jchip/playwright that referenced this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants