Skip to content

OAuth 2 support#225

Merged
thebaer merged 6 commits into
developfrom
T705-oauth
Dec 31, 2019
Merged

OAuth 2 support#225
thebaer merged 6 commits into
developfrom
T705-oauth

Conversation

@ngerakines

@ngerakines ngerakines commented Dec 19, 2019 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This PR introduces OAuth 2.0 support as a client application integrating against a OAuth provider.

Change Log

Added

  • github.com/writeas/writefreely/db package that contains database and storage utility and helper code
  • Database testing utility code in github.com/writeas/writefreely/main_test.go
  • OAuth 2.0 HTTP handlers and wired them into /oauth/write.as and /oauth/callback
  • The users_oauth and oauth_client_state tables with migrations (v4).

Changed

  • The configuration structure to include OAuth application configuration.
  • I have signed the CLA

@ngerakines ngerakines added the enhancement Proposed enhancements to current behavior label Dec 19, 2019
@ngerakines ngerakines requested review from a user and thebaer December 19, 2019 17:08
@ngerakines ngerakines self-assigned this Dec 19, 2019
@thebaer thebaer added this to the 0.12 milestone Dec 19, 2019
@ngerakines ngerakines marked this pull request as ready for review December 24, 2019 18:59
thebaer
thebaer requested changes Dec 27, 2019
View reviewed changes

@thebaer thebaer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small notes after reading through. I'll be able to actually run / test later today or tomorrow, and give my final review then.

Comment thread config/config.go
Comment thread database.go Outdated
@thebaer

thebaer commented Dec 28, 2019

Copy link
Copy Markdown
Member

Thanks. So how can I test and verify this? Do you have sample config values if I'm running Write.as locally?

@ngerakines ngerakines requested a review from thebaer December 29, 2019 21:48
@ngerakines

ngerakines commented Dec 29, 2019

Copy link
Copy Markdown
Collaborator Author

Thanks. So how can I test and verify this? Do you have sample config values if I'm running Write.as locally?

I sent my local setup to you privately.

@ngerakines ngerakines mentioned this pull request Dec 30, 2019
Merged
1 task
@thebaer
Add logging in viewOauthCallback()
39d0f1d 
Ref T705
@thebaer
Check for error response in code exchange
6bcc4cf 
This checks to see if we get a response with a populated `error` field
in exchangeOauthCode(). If so, we return that error message as an error,
to ensure the callback logic doesn't continue with a bad response.

Ref T705
thebaer
thebaer requested changes Dec 30, 2019
View reviewed changes

@thebaer thebaer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After testing, everything looks good! I committed a few changes I needed: added some helpful logging and fixed some error-passing during the code exchange process.

Last thing: we should update the database table names to be consistent with the current naming scheme. Then we'll get this merged!

Comment thread migrations/v4.go Outdated
Comment thread migrations/v4.go Outdated
@thebaer

thebaer commented Dec 31, 2019

Copy link
Copy Markdown
Member

Perfect -- thanks @ngerakines! Merging now.

@thebaer thebaer merged commit f343ceb into develop Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thebaer thebaer thebaer requested changes

Assignees

@ngerakines ngerakines

Labels

enhancement Proposed enhancements to current behavior

Milestone

0.12

Development

Successfully merging this pull request may close these issues.

2 participants

@ngerakines @thebaer