[Fast Refresh] Unify hot reload type resolution - #36962
Merged
Merged
Conversation
Previously resolveForwardRefForHotReloading was treated as a special case. It's simpler to move this logic to updateForwardRef which mirrors how updateMemoComponent and mountLazyComponent already are, and it allows us to unify to a single resolveTypeForHotReloading which we'll use in the next commit. Since .type is no longer changing we need to set didReceiveUpdate manually. This behavior is already tested in "can update forwardRef render function in isolation".
github-actions
Bot
added
the
React Core Team
sophiebits
marked this pull request as ready for review
July 8, 2026 07:20
|
Comparing: 5a90a5a...d3ec1b0 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
gaearon
approved these changes
Jul 8, 2026
github-actions Bot
pushed a commit
that referenced
this pull request
Jul 8, 2026
Previously resolveForwardRefForHotReloading was treated as a special case. It's simpler to move this logic to updateForwardRef which mirrors how updateMemoComponent and mountLazyComponent already are, and it allows us to unify to a single resolveTypeForHotReloading which we'll use in the next commit. Since .type is no longer changing we need to set didReceiveUpdate manually. This behavior is already tested in "can update forwardRef render function in isolation". DiffTrain build for [df4bd1b](df4bd1b)
github-actions Bot
pushed a commit
that referenced
this pull request
Jul 8, 2026
Previously resolveForwardRefForHotReloading was treated as a special case. It's simpler to move this logic to updateForwardRef which mirrors how updateMemoComponent and mountLazyComponent already are, and it allows us to unify to a single resolveTypeForHotReloading which we'll use in the next commit. Since .type is no longer changing we need to set didReceiveUpdate manually. This behavior is already tested in "can update forwardRef render function in isolation". DiffTrain build for [df4bd1b](df4bd1b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously resolveForwardRefForHotReloading was treated as a special
case. It's simpler to move this logic to updateForwardRef which
mirrors how updateMemoComponent and mountLazyComponent already are,
and it allows us to unify to a single resolveTypeForHotReloading which
we'll use in the next commit.
Since .type is no longer changing we need to set didReceiveUpdate
manually.
This behavior is already tested in "can update forwardRef render
function in isolation".