Skip to content

docs(event-handler): Fix REST API - HTTP Methods documentation - #1936

Merged
rubenfonseca merged 1 commit into
aws-powertools:developfrom
leandrodamascena:docs/options
Feb 17, 2023
Merged

rubenfonseca merged 1 commit into
aws-powertools:developfrom
leandrodamascena:docs/options

Conversation

@leandrodamascena

Copy link
Copy Markdown
Contributor

Issue number: #1922

Summary

Changes

Removed HTTP options from the documentation. Since we are not implementing this HTTP Method, the documentation was wrong.

User experience

Before
image

After
image

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena
leandrodamascena requested a review from a team as a code owner February 16, 2023 16:17
@leandrodamascena
leandrodamascena requested review from rubenfonseca and removed request for a team February 16, 2023 16:17
@boring-cyborg boring-cyborg Bot added the documentation Improvements or additions to documentation label Feb 16, 2023
@pull-request-size pull-request-size Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 16, 2023
@leandrodamascena leandrodamascena linked an issue Feb 16, 2023 that may be closed by this pull request
1 task done

@rubenfonseca rubenfonseca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rubenfonseca
rubenfonseca merged commit 49c8268 into aws-powertools:develop Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation event_handlers size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs: HTTP options not supported in decorator

2 participants