Repository navigation
Conversation
…opes iOS providerData used a photoURL key Dart never reads, Android ignored a null tenantId, and Facebook sign-in dropped scopes on the method channel.
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
FirebaseAuth.setTenantId rejects null, so writing it on every auth call throws for apps that have no tenant.
Yahoo landed on main in the same converter. Both branches and both tests stay.
fromJson stays green if the Apple provider map goes back to photoURL. This reload test reads the password provider photo, which is the value getProviderData writes.
Description
Two silent-wrong Auth paths, neither of which #18820 covers (that PR is Yahoo, ActionCodeSettings, and
updateProfile).On iOS,
PigeonParser.getProviderDatawrote the provider photo asphotoURL. DartUserInfo.fromJsonreadsphotoUrl, which is also what Android writes. Provider photos from Apple were alwaysnullin Dart. This PR only changes that map key.isEmailVerifiedis unchanged. macOS uses the same Swift file.convertToOAuthProvideralready kept scopes and custom parameters for Google, Microsoft, GitHub, Apple, Twitter, and Yahoo. Yahoo landed on main in #18820. Facebook went through unconverted, sosignInWithProviderdropped Facebook scopes and parameters. The new branch matches the Google and Yahoo ones, including.cast<String, String>()on parameters. This branch keeps both.Related Issues
None found.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
Test plan
flutter testonconvert_auth_provider_test.dartanduser_info_test.dart.should preserve providerData photoURL after reload.firebase_authunit tests and auth e2e.user_info_test.dartchecks thatfromJsonreadsphotoUrl. The integration test reads the password provider's photo fromcurrentUser.providerDataafterupdatePhotoURLandreload, which is the mapPigeonParser.getProviderDatawrites. Yahoo and Facebook each have a converter test.