Repository navigation
Conversation
…d by Symbol.species
gibson042
approved these changes
Oct 30, 2026
linusg
approved these changes
Oct 30, 2026
linusg
left a comment
linusg
left a comment
Member
There was a problem hiding this comment.
I find this note of limited value, all other TA builtins using TypedArraySpeciesCreate omit it.
|
The rendered spec preview for this PR is available as a single page at https://tc39.es/ecma262/pr/4057 and as multiple pages at https://tc39.es/ecma262/pr/4057/multipage . |
Member
Author
None of the other such builtins have descriptions at all; it's only this one where there is a description that could be (and is) rendered incorrect by the absence of this note. |
Member
|
Yes, poor wording on my part. This change is correct, but I don't think the note is all that useful to begin with (or should be mirrored to the other methods if anyone disagrees). Separate change though. |
linusg
reviewed
Oct 30, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the issue identified in #4014 by @JinDX, but I wrote my own wording that I prefer.
I considered leaving out this detail, especially in light of #3450, but since it has potential security implementations if different parts of an implementation make different assumptions here it seemed worth including. I originally tried to enumerate how it could change the behavior but doing so precisely makes it pretty wordy so I didn't bother.