Skip to content

Conversation

@ichernetsky-cf
Copy link
Contributor

Fixes CC-5749.

This is to remove a field that was deprecated many months ago and not returned by server anymore.


  • Tests
    • Tests included
    • Tests not necessary because: Some tests that use the field in question are actually dropped too.
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: This field is not used in the documentation.
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: Containers are not supported in V3.

@ichernetsky-cf ichernetsky-cf requested review from a team as code owners November 26, 2025 17:47
@changeset-bot
Copy link

changeset-bot bot commented Nov 26, 2025

🦋 Changeset detected

Latest commit: 7d258c0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 26, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11437

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11437

miniflare

npm i https://pkg.pr.new/miniflare@11437

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11437

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11437

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11437

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11437

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11437

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11437

wrangler

npm i https://pkg.pr.new/wrangler@11437

commit: 7d258c0

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Nov 27, 2025
@ichernetsky-cf ichernetsky-cf force-pushed the ichernetsky/CC-5749-drop-observability-logging branch from 0b5225f to f25dc8d Compare December 1, 2025 01:54
@ichernetsky-cf
Copy link
Contributor Author

@edmundhung I have re-run the Windows CI job a dozen times to no avail. Its failures do not seem to be related to this change. Should I keep re-running it? I can at least try rebasing my PR at more time

@edmundhung
Copy link
Member

@ichernetsky-cf Let's rebase it once more. We have merged some fixes to make tests less flaky yesterday and also this morning. Sorry for the trouble!

cc: @jamesopstad

@ichernetsky-cf ichernetsky-cf force-pushed the ichernetsky/CC-5749-drop-observability-logging branch 2 times, most recently from 5b31890 to b0d6116 Compare December 3, 2025 13:10
@ichernetsky-cf ichernetsky-cf force-pushed the ichernetsky/CC-5749-drop-observability-logging branch from b0d6116 to a537620 Compare December 15, 2025 16:23
@petebacondarwin petebacondarwin force-pushed the ichernetsky/CC-5749-drop-observability-logging branch from a537620 to a27b9db Compare December 23, 2025 12:18
@petebacondarwin petebacondarwin force-pushed the ichernetsky/CC-5749-drop-observability-logging branch from a27b9db to 7d258c0 Compare December 23, 2025 16:02
@petebacondarwin petebacondarwin merged commit 9e360f6 into cloudflare:main Dec 23, 2025
40 of 42 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Dec 23, 2025
AmirSa12 pushed a commit to AmirSa12/workers-sdk that referenced this pull request Jan 5, 2026
…flare#11437)

* CC-5749 Drop deprecated containers observability.logging field

* Mark the changes as minor

Co-authored-by: Edmund Hung <[email protected]>

---------

Co-authored-by: Edmund Hung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants