Skip to content

Correct plugin main file in bootstrap in scaffolded test#335

Merged
swissspidy merged 2 commits intowp-cli:mainfrom
ernilambar:190-plugin-bootstrap
Apr 26, 2024
Merged

Correct plugin main file in bootstrap in scaffolded test#335
swissspidy merged 2 commits intowp-cli:mainfrom
ernilambar:190-plugin-bootstrap

Conversation

@ernilambar
Copy link
Member

Fixes #190

  • Use correct plugin main file in tests/bootstrap.php for in scaffolded tests
  • Fallback name will be same as of now plugin-slug.php
  • Feature test is also added

@ernilambar ernilambar marked this pull request as ready for review April 17, 2024 06:50
@ernilambar ernilambar requested a review from a team as a code owner April 17, 2024 06:50
Copy link
Member

@swissspidy swissspidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought there was an easier way to get the main file from a slug, but apparently not

@swissspidy swissspidy added the command:scaffold-plugin-tests Related to 'scaffold plugin-tests' command label Apr 26, 2024
@swissspidy swissspidy added this to the 2.3.0 milestone Apr 26, 2024
@swissspidy swissspidy merged commit 7a7d145 into wp-cli:main Apr 26, 2024
@swissspidy
Copy link
Member

wp-cli/wp-cli#5935

@ernilambar ernilambar deleted the 190-plugin-bootstrap branch August 7, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

command:scaffold-plugin-tests Related to 'scaffold plugin-tests' command

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scaffolding plugin tests manually loads wrong file

2 participants