Check if the post is distributed, and if it is apply the author filter#1035
Merged
Conversation
peterwilsoncc
left a comment
Collaborator
There was a problem hiding this comment.
Tests well, thanks Garth.
I've made one suggestion inline.
Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>
peterwilsoncc
approved these changes
May 8, 2023
peterwilsoncc
left a comment
Collaborator
There was a problem hiding this comment.
LGMT, checked on a variety of block and classic themes.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
If an author ID is specified in a call to
get_the_author_meta(), instead of returning the specified author blindly, we are also checking the post itself and whether or not it was distributed. If it was, we apply theget_the_author_display_nameandget_the_author_user_urlfilters as usual.Closes #1015
How to test the Change
Make sure you're using a theme that supports the block editor for this like Twenty Twenty-Two, as the Classic editor themes don't have an issue.
Override Author Bylineis checked.Override Author Bylinein the Distributor settings.Changelog Entry
Credits
Props @ggutenberg
Checklist: