Feature/397#1036
Conversation
|
I have to Apply condition based Title for PluginDocumentSettingPanel and for that I had created const and added that const in title as below but somehow it is not working. Can you please check once?
|
|
I have integrated this feature in Modal but Need to setup design so can you please assign one designer for the same? |
@peterwilsoncc , You can ignore this as its been resolved. |
ravinderk
left a comment
There was a problem hiding this comment.
We can hold the review. I raised a question on issue #397 (comment)
iamdharmesh
left a comment
There was a problem hiding this comment.
Thanks for working on this @faisal-alvi. Great work here, I have added 2 minor comments. Also, for me the "Unlink" button is disabled and I am also not able to click (X) on the popup. Could you please help to check?
Thank you.
Sidsector9
left a comment
There was a problem hiding this comment.
Tests well 👍 , Approving not merging yet.
@jeffpaul following up on the comment by Ravinder here - #397 (comment)
cc: @dkotter as Jeff is on PTO.
If it's cool with you then it's good to go.
I think I agree that these icons could be clearer but I also don't have a great suggestion in mind. I think we're fine to ship this as-is and we can iterate on it later. That said, I see there's a couple comments by @iamdharmesh that need addressed and also seeing a bunch of eslint issues we should clean up. Once those are taken care of, I'm good to get this merged in |
Co-authored-by: Dharmesh Patel <dspatel44@gmail.com>
Co-authored-by: Dharmesh Patel <dspatel44@gmail.com>
iamdharmesh
left a comment
There was a problem hiding this comment.
Thanks for the changes @faisal-alvi @Sidsector9. LGTM.
Just added a minor suggestion but nothing blocker.
Co-authored-by: Dharmesh Patel <dspatel44@gmail.com>

Description of the Change
Closes #397
How to test the Change
Changelog Entry
Credits
Props @roshniahuja @faisal-alvi
Checklist: