Skip to content

Feature/397#1036

Merged
jeffpaul merged 23 commits into
developfrom
feature/397
Aug 20, 2024
Merged

Feature/397#1036
jeffpaul merged 23 commits into
developfrom
feature/397

Conversation

@roshniahuja

@roshniahuja roshniahuja commented Mar 21, 2023

Copy link
Copy Markdown
Contributor

Description of the Change

  • In Posts table view, include better details in Distributor icon column, add Pushed/Pulled/Linked/Unlinked in hover details for each item (see: https://cldup.com/kVpFJIy8bM.png)

image

Closes #397

How to test the Change

Changelog Entry

Added - Impvoed Pulled Content Management

Credits

Props @roshniahuja @faisal-alvi

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@roshniahuja

Copy link
Copy Markdown
Contributor Author

@peterwilsoncc ,

I have to Apply condition based Title for PluginDocumentSettingPanel and for that I had created const and added that const in title as below but somehow it is not working. Can you please check once?

title={ DistributorTitle }

https://github.com/10up/distributor/blob/88761bed134235ead796ed9b9fa0e651c4182edb/assets/js/gutenberg-plugin.js#:~:text=)%3B-,/**,%7D%3B,-/**

@roshniahuja

Copy link
Copy Markdown
Contributor Author

@jeffpaul ,

I have integrated this feature in Modal but Need to setup design so can you please assign one designer for the same?

@roshniahuja roshniahuja added the needs:design This requires design to resolve. label Mar 21, 2023
@roshniahuja

Copy link
Copy Markdown
Contributor Author

@peterwilsoncc ,

I have to Apply condition based Title for PluginDocumentSettingPanel and for that I had created const and added that const in title as below but somehow it is not working. Can you please check once?

title={ DistributorTitle }

https://github.com/10up/distributor/blob/88761bed134235ead796ed9b9fa0e651c4182edb/assets/js/gutenberg-plugin.js#:~:text=)%3B-,/**,%7D%3B,-/**

@peterwilsoncc , You can ignore this as its been resolved.

@jeffpaul jeffpaul linked an issue Apr 10, 2023 that may be closed by this pull request
6 tasks
@jeffpaul jeffpaul added this to the 2.0.0 milestone Apr 27, 2023
@ravinderk ravinderk self-requested a review June 8, 2023 15:19

@ravinderk ravinderk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can hold the review. I raised a question on issue #397 (comment)

@jeffpaul jeffpaul modified the milestones: 2.0.0, 2.1.0 Jun 14, 2023
@vikrampm1 vikrampm1 requested review from faisal-alvi and removed request for peterwilsoncc July 3, 2024 21:09
@faisal-alvi faisal-alvi removed their request for review July 4, 2024 18:33
@faisal-alvi faisal-alvi removed the request for review from a team July 5, 2024 16:46
@github-actions github-actions Bot added the needs:code-review This requires code review. label Jul 5, 2024
@faisal-alvi faisal-alvi removed needs:code-review This requires code review. needs:design This requires design to resolve. labels Jul 5, 2024

@iamdharmesh iamdharmesh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @faisal-alvi. Great work here, I have added 2 minor comments. Also, for me the "Unlink" button is disabled and I am also not able to click (X) on the popup. Could you please help to check?

image

Thank you.

Comment thread assets/js/gutenberg-plugin.js Outdated
Comment thread assets/js/gutenberg-plugin.js Outdated
@github-actions github-actions Bot added the needs:code-review This requires code review. label Jul 14, 2024
@Sidsector9 Sidsector9 requested review from iamdharmesh and removed request for iamdharmesh July 14, 2024 18:31
Sidsector9
Sidsector9 previously approved these changes Jul 14, 2024

@Sidsector9 Sidsector9 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well 👍 , Approving not merging yet.

@jeffpaul following up on the comment by Ravinder here - #397 (comment)

cc: @dkotter as Jeff is on PTO.

If it's cool with you then it's good to go.

@dkotter

dkotter commented Jul 15, 2024

Copy link
Copy Markdown
Collaborator

following up on the comment by Ravinder here - #397 (comment)

I think I agree that these icons could be clearer but I also don't have a great suggestion in mind. I think we're fine to ship this as-is and we can iterate on it later.

That said, I see there's a couple comments by @iamdharmesh that need addressed and also seeing a bunch of eslint issues we should clean up. Once those are taken care of, I'm good to get this merged in

Co-authored-by: Dharmesh Patel <dspatel44@gmail.com>
@faisal-alvi faisal-alvi requested a review from iamdharmesh July 22, 2024 14:48
iamdharmesh
iamdharmesh previously approved these changes Jul 22, 2024

@iamdharmesh iamdharmesh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @faisal-alvi @Sidsector9. LGTM.

Just added a minor suggestion but nothing blocker.

Comment thread includes/syndicated-post-ui.php Outdated
Co-authored-by: Dharmesh Patel <dspatel44@gmail.com>
@faisal-alvi faisal-alvi requested a review from iamdharmesh July 23, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs:code-review This requires code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update pulled content management

8 participants