Use is_using_gutenberg() wrapper for use_block_editor_for_post().#1056
Merged
Conversation
This ensure against fatal errors in versions of WordPress prior to version 6.1.0. The function is only available within wp-admin in these version of WordPress.
29 tasks
ravinderk
previously approved these changes
May 26, 2023
ravinderk
left a comment
Contributor
There was a problem hiding this comment.
@peterwilsoncc it is working as expected.
I want to suggest two minor changes to syndicatable function. This is not a blocker for this pull request.
- Return bool on line 86
- If we are accessing global
$postthen define it at the beginning of the function.
Collaborator
Author
|
@ravinderk I've pushed a couple of commits making those changes. This has dismissed your review so are you able to reapprove? |
ravinderk
approved these changes
May 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensure against fatal errors in versions of WordPress prior to version 6.1.0. The function is only available within wp-admin in these version of WordPress.
Description of the Change
Use
is_using_gutenberg()in place ofuse_block_editor_for_post()to avoid fatal errors in older versions of WordPress.Closes #1055
How to test the Change
developthe post will not save.Changelog Entry
Credits
Props @peterwilsoncc, @ravinderk
Checklist: