fix/warning: Undefined array key "id"#1247
Merged
Merged
Conversation
github-actions
Bot
added
the
needs:feedback
|
@Sidsector9 thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this? |
github-actions
Bot
added
needs:code-review
peterwilsoncc
approved these changes
Jul 22, 2024
peterwilsoncc
left a comment
peterwilsoncc
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, can reproduce warning on develop and fix on this branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR fixes a PHP warning shown on the "Pull Content" page.
How to test the Change
Create 2 multisites env of types subdomain and subdir.
Create pages and posts in both sites.
Add the subdir site as external connection to subdomain site.
Visit "Pull Content" and observe the error on
develop.Switch to the fix branch and see the error is fixed.
Changelog Entry
Credits
Props @Sidsector9
Checklist: