Fix disabled buttons in distributed posts#1252
Merged
Merged
Conversation
|
@phpbits thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this? |
github-actions
Bot
added
needs:feedback
1 task
faisal-alvi
approved these changes
Aug 14, 2024
Contributor
There was a problem hiding this comment.
Thanks for the fix @phpbits!
✅ Tests well.
I've tested in the following setups, and it works fine:
| Setup | WordPress Version | Status |
|---|---|---|
| External connection | v6.6.1 |
✅ |
| External connection | v6.4.3 |
✅ |
| Multisite network (Internal) | v6.5.5 |
✅ |
Note: Ignoring E2E failures as they are unrelated and also occurring in the develop branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR fixes the #1249 issues.
Closes #1249
How to test the Change
Update the site you distributed the post to WP 6.6 and/or distribute a post with the "As draft" checkbox checked to a site that is running WP 6.6. Observe that the Publish button is enabled and publish button is working.
Changelog Entry
Credits
Props @phpbits
Checklist: