Potential fix for code scanning alert no. 3: DOM text reinterpreted as HTML#1316
Merged
dkotter merged 2 commits intoJul 8, 2025
Merged
Conversation
…s HTML Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
github-actions
Bot
added
the
needs:refresh
dkotter
reviewed
Jul 8, 2025
github-actions
Bot
removed
the
needs:refresh
dkotter
approved these changes
Jul 8, 2025
github-project-automation
Bot
moved this from Code Review
to QA Testing
in Open Source Practice
github-project-automation
Bot
moved this from QA Testing
to Done
in Open Source Practice
github-actions
Bot
added
the
needs:feedback
|
@Sidsector9 thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/10up/distributor/security/code-scanning/3
To fix this issue, we need to ensure that the user input from
searchField.valueis properly sanitized or encoded before being used in the URL. The best way to do this is to use a library that provides functions for escaping or encoding user input to prevent XSS attacks.In this case, we can use the
encodeURIComponentfunction, which is a built-in JavaScript function that encodes a URI component by replacing each instance of certain characters by one, two, three, or four escape sequences representing the UTF-8 encoding of the character.Suggested fixes powered by Copilot Autofix. Review carefully before merging.