Plugin Base + API Endpoint #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkotter
requested changes
Mar 4, 2025
faisal-alvi
requested changes
Mar 5, 2025
Contributor
faisal-alvi
left a comment
faisal-alvi
left a comment
There was a problem hiding this comment.
Thanks for your work on this! I see Darin has already provided feedback and covered most of the key points. I’ve also added a few suggestions for consideration, mainly around handling token enc/decryption more safely and ensuring consistency in how tokens are retrieved. Let me know what you think!
…ings in i18n methods.
Collaborator
Author
|
PR updates according to reviews, however we should merge #4 as that removes some of the items that were commented on in this PR. |
dkotter
reviewed
Mar 10, 2025
dkotter
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Jobberclass for executing GraphQL Queries.Authclass for handling authorizationEncryptionclass for encrypting tokens.jobber/v1/tokensAPI endpoint for accepting the tokens from the middleware.Closes #1