Update iframe height based on form type #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkotter
reviewed
May 9, 2025
blocks/forms/edit.js
Outdated
| style={{ | ||
| border: '1px dashed #E0E0E0', | ||
| height: '500px', | ||
| height: formType === 'request' ? '1630px' : '600px', |
Collaborator
There was a problem hiding this comment.
In my testing, the Booking form was about 340px tall so 600px adds lots of extra white space. I know it's hard to know for sure the height of each of those forms since I'm assuming it will depend on how each person has these configured but wondering if reducing it from 600 to 400 is a nicer middle ground?
Contributor
Author
There was a problem hiding this comment.
Yeah, it was around 590px for me on the front end – not sure why there’s a difference, but agreed that 400px seems like a nicer middle ground.
dkotter
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
It was observed that the Request form requires a height of 1630 pixels, while the Booking form needs 600 pixels. This PR updates the block editor to apply these required heights accordingly.
Note: This change only affects the block editor view and does not impact the front-end display.
Closes #42
How to test the Change
Changelog Entry
Credits
Props @ankitguptaindia @dkotter @faisal-alvi
Checklist: