-
Notifications
You must be signed in to change notification settings - Fork 42
SC: Support long sync call function names #362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
suggested changes
Jul 9, 2025
heifner
suggested changes
Jul 11, 2025
tools/include/eosio/utils.hpp
Outdated
|
|
||
| // Validate the input `str` is a valid C/C++ identifier | ||
| template <typename Lambda> | ||
| void validate_identifier( const std::string& str, Lambda&& error_handler ) { |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably should rename to validate_hash_id.
tools/include/eosio/utils.hpp
Outdated
| } | ||
| } | ||
|
|
||
| uint64_t identifier_to_id(std::string str) { |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably should rename to to_hash_id
heifner
approved these changes
Jul 11, 2025
spoonincode
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Work in progress:
This PR adds support of long sync call function names. Now a sync call function name can be any valid C++ identifier with max length of 128 characters. This provides much flexibilities in choosing sync call function names than using
eosio::name.Please note, this is a quick implementation for dev-preview-1. Internal implementation might be changed in dev-preview-2 but user-faced interface should keep the same.
Resolves #361
The following is a working example of using C++ identifiers for sync call function names.
ABI for sync calls looks like
API Changes
Documentation Additions