Skip to content

IF: Use proposer diffs in instant_finality_extension #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
heifner merged 3 commits into from
May 10, 2024
Merged

IF: Use proposer diffs in instant_finality_extension #125

heifner merged 3 commits into from
May 10, 2024

Conversation

@heifner
Copy link
Contributor

@heifner heifner commented May 9, 2024

Instead of placing the entire producer (proposer) schedule in the instant_finality_extension, only put a diff of the proposer schedule in the extension.

Along with #118 Resolves #5

@heifner heifner added OCI Work exclusive to OCI team consensus-protocol Change to the consensus protocol. Impacts light client validation. labels May 9, 2024
@heifner heifner linked an issue May 9, 2024 that may be closed by this pull request
Use diffs for proposer finalizer policy and proposer policy in block_header extension #5
Closed
greg7mdp
greg7mdp approved these changes May 9, 2024
View reviewed changes
Base automatically changed from GH-5-diff-policies to main May 9, 2024 21:43
@heifner heifner requested a review from linh2931 May 10, 2024 11:31
@heifner heifner merged commit 5ce056a into main May 10, 2024
@heifner heifner deleted the GH-5-diff-producers branch May 10, 2024 13:01
@ericpassmore
Copy link
Contributor

ericpassmore commented May 10, 2024

Note:start
group: IF
category: PERFORMANCE
summary: Instead of placing the entire producer proposed schedule in the instant_finality_extension, only put a diff of the producer proposed schedule in the extension.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

@linh2931 linh2931 linh2931 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

consensus-protocol Change to the consensus protocol. Impacts light client validation. OCI Work exclusive to OCI team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use diffs for proposer finalizer policy and proposer policy in block_header extension

4 participants

@heifner @ericpassmore @greg7mdp @linh2931