SC: enforce max_sync_call_depth for nested and recursive sync calls
#1285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
suggested changes
Mar 28, 2025
… of inline action recurse_depth
heifner
suggested changes
Mar 31, 2025
libraries/chain/host_context.cpp
Outdated
| // If the call is initiated from an apply_context (an action), it is the first | ||
| // level of a sync call by the action, set the depth to 1. | ||
| // Otherwise the call is from another sync call, increment the depth by 1. | ||
| const uint32_t depth = dynamic_cast<apply_context*>(this) ? 1 : sync_call_depth + 1; |
Contributor
There was a problem hiding this comment.
I think we should refactor to remove this dynamic_cast. Can't you just pass in the depth instead?
Contributor
Author
There was a problem hiding this comment.
Yes, it can be removed because sync_call_depth default initial value is 0. Now the code is cleaner. Thanks.
…f functions which should have never be called
…r returning a 0-length value
heifner
approved these changes
Apr 2, 2025
SC: Tests for sync calls without parameters, not returning a value, or returning a 0-length value
SC: privilege support
SC: Enforce host function preconditions for sync calls
spoonincode
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforce on chain configuration parameter
max_sync_call_depthfor nested and recursive sync calls. Once the depth is reached, the call is aborted.Notable things about the two new two tests for the PR:
One test has one function making sync calls to itself recursively, another has two functions on different accounts calling each other recursively. Both tests show sync calls work correctly when max depth is not reached, and calls are aborted when max depth is reached.
The test WASM contracts utilize
senderandreceiverarguments fromsync_callentry point, which demonstrates those two arguments are set correctly.Resolves #1268