SC: Add SHiP support for sync call traces #1340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoonincode
reviewed
Apr 10, 2025
libraries/state_history/abi.cpp
Outdated
| ] | ||
| }, | ||
| { | ||
| "name": "sync_call_trace", "fields": [ |
Contributor
There was a problem hiding this comment.
I guess this is where my comment https://github.com/AntelopeIO/abieos/pull/42/files#r2036377296 should have originally gone. ship does a good job versioning everything, so I think we ought to have this as sync_call_trace_v0 to follow existing pattern.
I think it probably ought to be a variant as well, to match existing established pattern. Not sure how problematic that may be off hand.
spoonincode
approved these changes
Apr 14, 2025
heifner
approved these changes
Apr 29, 2025
| { "name": "sender_ordinal", "type": "varuint32" }, | ||
| { "name": "receiver", "type": "name" }, | ||
| { "name": "read_only", "type": "bool" }, | ||
| { "name": "data", "type": "bytes" }, |
Contributor
There was a problem hiding this comment.
Is data something we should expand into a versioned type? It is not clear to me what is expected for this data. How would a user expand it?
Contributor
Author
There was a problem hiding this comment.
That would be similar to data in action. The user can parse it once ABI is ready.
This was referenced May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sync call traces to SHiP.
Depending on Abieos AntelopeIO/abieos#42
Resolves #1334