-
Notifications
You must be signed in to change notification settings - Fork 33
SC: Add sync calls to deep mind log #1439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Why do we not have the call data & call return value & readonlyness etc? Deepmind historically has been the most exhaustive history output so not sure why it has barely anything vs what we're doing in ship & trace |
It correlates |
|
o yeah should have remembered that from #1333 👍 |
|
Need to add to PR description the change in |
Thanks. Done. |
As sync calls can make nested sync calls, we need to log more information to help Deepmind to correlate an action/sync call to operations. We implement the following minimum changes to deepmind logging:
execution_id. Whenever an action starts or a sync call is made, incrementexecution_idby 1.action_idwithexecution_id.For the following action/call example,
you would see deepmind logging as (other parameters of table operations are omitted for simplicity)
Please note, the
action_tracesinsidetransaction_traceinAPPLIED_TRANSACTIONhas been updated to include sync call traces.action_traceshas two new fields:See
spring/libraries/chain/include/eosio/chain/trace.hpp
Line 22 in 6cf29e7
call_traceResolves #1221