-
Notifications
You must be signed in to change notification settings - Fork 33
SC: Pretty print sync call consoles from contract in call hierarchy #1641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| std::string output; | ||
| output += header; | ||
| output += expanded; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could avoid this copy by using output from the start and append as you go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we use output from the start and append as we go, we will append header at the beginning. Then we need to use "if output is equal to header" at the end to determine if the console has anything, because we don't want to output anything if console (including sync calls') is empty.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could track that via a bool, but doesn't really matter.
… name such that it won't have conflicts if in the future the error massage name becomes valid
This PR implements pretty print sync call consoles from contract in call hierarchy.
Resolves #1579
cleossupport of pretty printing and call traces is tracked by #1628.Example of both caller and callee have consoles:
Example of only callee has console:
Example of only caller has console: