Create block_state for block_state_legacy for snapshot correctly during transition #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg7mdp
reviewed
Apr 17, 2024
heifner
suggested changes
Apr 18, 2024
…d make it return status and transactionId
heifner
reviewed
Apr 19, 2024
| numTrxGenerators=2 | ||
| Print("Stand up cluster") | ||
| # For now do not load system contract as it does not support setfinalizer | ||
| specificExtraNodeosArgs = { irreversibleNodeId: "--read-mode irreversible"} |
Contributor
There was a problem hiding this comment.
Please add a snapshot from the irreversibleNode and make sure it can be used to start a node as well.
greg7mdp
approved these changes
Apr 19, 2024
…entations (Legacy and Savanna) of block state and using correct Genesis block
…estart node with it
heifner
approved these changes
Apr 22, 2024
greg7mdp
reviewed
Apr 22, 2024
libraries/chain/controller.cpp
Outdated
| assert(!legacy_branch.empty()); // should have started with a block_state chain_head or we transition during replay | ||
| // transition to savanna | ||
| block_state_ptr prev; | ||
| block_state_ptr prev = chain_head_trans_svnn_block; // If chain_head_trans_svnn_block should not null, it indicates replay from snapshot. |
Contributor
There was a problem hiding this comment.
Instead of these two comments, why not have a boolean:
bool replay_from_snapshot = !chain_head_trans_svnn_block;
If you keep the comment, please fix small typo, and put comment on separate line to avoid excessively long lines.
Suggested change
| block_state_ptr prev = chain_head_trans_svnn_block; // If chain_head_trans_svnn_block should not null, it indicates replay from snapshot. | |
| block_state_ptr prev = chain_head_trans_svnn_block; // If chain_head_trans_svnn_block is not null, it indicates replay from snapshot. |
greg7mdp
approved these changes
Apr 22, 2024
Contributor
|
Note:start |
greg7mdp
pushed a commit
that referenced
this pull request
Apr 25, 2025
work around ASAN intercepting `mlock()` as a noop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved #15