[Helm] Adding support for plugins configuration

[carlos-rodrigues-8x8]

What does this PR do?

Added configuration for built-in plugins through well defined properties.
Added support for configuring custom plugins.

Motivation

Contribute for the community.

Related issues

#2436

Additional Notes

For testing propose:

• Create values_test.yaml with content:

arcadedb:
  plugins:
    gremlin:
      enabled: true
    prometheus:
      enabled: true

• Execute the command the following command inside k8s/helm directory:

helm template . --namespace foo -f values.yaml -f values_test.yml 

• Validate the output:
  • service manifest:

apiVersion: v1
kind: Service
metadata:
  name: release-name-arcadedb
  labels:
    app: arcadedb
    helm.sh/chart: arcadedb-0.1.0
    app.kubernetes.io/name: arcadedb
    app.kubernetes.io/instance: release-name
    app.kubernetes.io/version: "25.2.1"
    app.kubernetes.io/managed-by: Helm
spec:
  clusterIP: None
  ports:
    - port: 2480
      targetPort: http
      protocol: TCP
      name: http
    - port: 2424
      targetPort: rpc
      protocol: TCP
      name: rpc

    - port: 8082
      targetPort: 8082
      protocol: TCP
      name: gremlin-port
  selector:
    app.kubernetes.io/name: arcadedb
    app.kubernetes.io/instance: release-name
---

• statefulset manifest:

...
            - -Darcadedb.server.plugins=GremlinServer:com.arcadedb.server.gremlin.GremlinServerPlugin,Prometheus:com.arcadedb.metrics.prometheus.PrometheusMetricsPlugin
          livenessProbe:
            httpGet:
...

Checklist

• I have run the build using mvn clean package command
• My unit tests cover both failure and success scenarios

[gemini-code-assist]

Summary of Changes

Hello @carlos-rodrigues-8x8, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This PR enhances the ArcadeDB Helm chart by introducing comprehensive support for configuring both built-in and custom plugins. It allows users to enable specific plugins and define their associated parameters, such as ports and class names, directly through the Helm values.yaml file, streamlining deployment and management of ArcadeDB instances with desired functionalities.

Highlights

• Centralized Plugin Configuration: Introduced new Helm templates (_helpers.tpl) to manage the configuration and dynamic generation of parameters for ArcadeDB plugins.
• Dynamic Service Port Exposure: The Helm service manifest (service.yaml) is now dynamically updated to expose ports for enabled plugins, ensuring network accessibility.
• Automated JVM Parameter Generation: The StatefulSet manifest (statefulset.yaml) is updated to automatically inject the necessary JVM parameters (-Darcadedb.server.plugins) based on the enabled plugins, simplifying server startup configuration.
• Extended values.yaml for Plugin Management: The values.yaml file now includes a dedicated arcadedb.plugins section with examples for configuring common built-in plugins (Gremlin, Postgres, Mongo, Redis, Prometheus) and a generic custom plugin, providing clear guidance for users.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds valuable support for configuring ArcadeDB plugins through Helm chart values. The implementation introduces new helper templates to manage plugin parameters and services, which is a great addition. However, I've identified a few issues that need addressing. There are a couple of bugs in the _arcadedb.plugin.ports helper related to port configuration for postgres and redis. More critically, the arcadedb.plugin.parameters template has flawed logic that will result in incorrect command-line arguments for the ArcadeDB server. I've also noticed some indentation issues in the commented-out examples in values.yaml that could confuse users. My review includes detailed suggestions to resolve these problems.

[robfrank]

@carlos-rodrigues-8x8 is it ready for review/merge?

[carlos-rodrigues-8x8]

@carlos-rodrigues-8x8 is it ready for review/merge?

Hey @robfrank, can you confirm if gremlin plugin default port is 8082? Thanks!

[robfrank]

Gremlin port is 8182

[carlos-rodrigues-8x8]

@robfrank you can go for it

[robfrank]

LGTM